Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLB display name to OCID map #486

Closed
wants to merge 1 commit into from
Closed

NLB display name to OCID map #486

wants to merge 1 commit into from

Conversation

pbenas
Copy link
Member

@pbenas pbenas commented Jan 16, 2025

Cache the mapping of the display name of a LB to an OCID to avoid looking it up again in each reconciliation.

Unit tests passed.

➜  oci-cloud-controller-manager git:(lb-name-caching) make test
Running tests...
./cmd/... ./pkg/...
(...)
ok  	github.com/oracle/oci-cloud-controller-manager/pkg/volume/provisioner/fss	1.122s	coverage: 47.0% of statements
➜  oci-cloud-controller-manager git:(lb-name-caching) echo $?
0

@pbenas
NLB display name to OCID map
a4a3aff 
Cache the mapping of the display name of a LB to an OCID to avoid looking it up
again in each reconciliation.

Signed-off-by: Petr Benas <petr.benas@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 16, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12806699163

Details

  • 42 of 110 (38.18%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 32.207%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/providers/oci/ccm.go 0 1 0.0%
pkg/oci/client/client_factory.go 0 1 0.0%
pkg/volume/provisioner/core/provisioner.go 0 1 0.0%
pkg/oci/client/client.go 0 5 0.0%
pkg/oci/client/utils.go 23 31 74.19%
pkg/oci/client/load_balancer.go 0 22 0.0%
pkg/oci/client/network_load_balancer.go 19 49 38.78%
Totals Coverage Status
Change from base Build 12118669558: 0.6%
Covered Lines: 5063
Relevant Lines: 15720
💛 - Coveralls

@pbenas pbenas closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbenas @coveralls